build: add tslint rule to enforce OnPush change detection #5707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a tslint rule that requires OnPush change detection on all library and CDK components. Relates to angular#5035.
crisbeto
added
blocked
googlebot
added
the
cla: yes
Contributor
|
@crisbeto looks like they've all merged! |
Member
|
We're currently stuck on an issue w/ the dialog |
ghost
mentioned this pull request
Member
Author
|
No longer relevant since this functionality is part of the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tslint rule that requires OnPush change detection on all library and CDK components.
Relates to #5035.
Note: we should defer merging this until all of the OnPush PRs have gone through. Also it uncovered that we were missing the
MdSidenavContainerfrom the list on #5035. I'll sort it out tomorrow.