build: fix rollup globals for examples package #5611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the rollup globals have been changed because the operators are no longer applied to the prototype (using `/add/` imports). This now causes some warnigns and invalid id's in the bundles of the Material examples because those still use the `/add/` imports in some examples.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jul 8, 2017
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
I don't see any harm in having this one config for all the package since it doesn't have any effect if you don't use the symbol.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the rollup globals have been changed because the operators are no longer applied to the prototype (using
/add/imports).This now causes some warnigns and invalid id's in the bundles of the Material examples because those still use the
/add/imports in some examples.Note: In theory we can also generate this object automatically as well, but since those are less operator it should be fine.
@jelbourn In the future I think it would be better if we also have a
rollup-config.jsfile for every package? (as in Angular core)