Skip to content

build: incorrect path mapping in editor tsconfig #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2017
Merged

build: incorrect path mapping in editor tsconfig #5591

merged 1 commit into from
Jul 7, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jul 7, 2017

  • The root tsconfig file used to have proper autocompletion in editors like WebStorm is currently not working correctly. The path to the @angular/cdk/testing package is mapped to a non-existing folder.

@devversion
build: incorrect path mapping in editor tsconifg
240fb18 
* The root tsconfig file used to have proper autocompletion in editors like WebStorm is currently not working correctly. The path to the `@angular/cdk/testing` package is mapped to a non-existing folder.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 7, 2017
jelbourn
jelbourn approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 7, 2017
@devversion devversion changed the title build: incorrect path mapping in editor tsconifg build: incorrect path mapping in editor tsconfig Jul 7, 2017
@mmalerba mmalerba merged commit 48e4e92 into angular:master Jul 7, 2017
@devversion devversion deleted the build/editor-tsconfig-fix branch July 7, 2017 22:05
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
@devversion @amcdnl
build: incorrect path mapping in editor tsconfig (angular#5591)
48356de 
* The root tsconfig file used to have proper autocompletion in editors like WebStorm is currently not working correctly. The path to the `@angular/cdk/testing` package is mapped to a non-existing folder.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @mmalerba