Skip to content

Conversation

@devversion
Copy link
Member

  • Recently we moved the inline script to the packaging directory and we cleaned up some logic. At this point the multiple style files inlining broke accidentally.
  • We joined the different styles using a comma inside of the inlined stylesheet (while we were trying to create a array). Instead it would be just easier to concatenate the styles using a space.

Before (incorrect)

styleUrls: ["AAA,  BBB"] // Note the incorrect comma between the different stylesheets

Now (correct)

styleUrls: ["AAA BBB"] // This is a simpler solution than creating a real array and it also works the same

Fixes #4910

* Recently we moved the inline script to the packaging directory and we cleaned up some logic. At this point the multiple style files inlining broke accidentally.
* We joined the different styles using a comma inside of the inlined stylesheet (while we were trying to create a array). Instead it would be just easier to concatenate the styles using a space.
@devversion devversion requested a review from jelbourn June 1, 2017 16:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 2, 2017
@mmalerba mmalerba merged commit 1d7b752 into angular:master Jun 2, 2017
@devversion devversion deleted the build/inline-multiple-styles branch June 3, 2017 09:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sidenav open/close missing animation

4 participants