build: no sourcemaps in inline styles #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In components inline styles there shouldn't be any Sourcemap reference. This adds bloat and also doesn't do anything right now. * No longer builds sourcemaps for all compiled SCSS. The sourcemaps don't work for development either (styles are inlined too) * Prebuilt themes no longer contain source-maps.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: A follow-up would be running the validate release task in a Cronjob or for master builds.
Note 2: It's basically just easier for us to not build sourcemaps for SCSS files at all. Because if we want to have sourcemaps for the prebuilt themes then we need a way to identify SCSS files that won't be inlined later (and therefore can have sourcemaps). All of our SCSS files are built in the same task so we can't differentiate between those.
Another option would be minifying again before a file will be inlined (this causes the minifier to run twice per file)