Skip to content

build: scss changes not live-reloading #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2017
Merged

build: scss changes not live-reloading #4870

merged 1 commit into from
May 30, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented May 29, 2017 •
edited
Loading

  • Sometimes the theme SCSS changes are not being reflected in the browser. This is because the demo-app theme is built from the SCSS mixins and those aren't rebuilt whenever CSS changes inside of Material.

@devversion devversion requested a review from jelbourn May 29, 2017 20:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 29, 2017
@devversion
build: scss changes not live-reloading
426de70 
* Sometimes the theme SCSS changes are not being reflected in the browser. This is because the demo-app theme is built from the SCSS mixins and those aren't rebuilt whenever CSS changes inside of Material.
@devversion devversion force-pushed the build/live-reload-theme-scss branch from b9685ab to 426de70 Compare May 29, 2017 20:04
jelbourn
jelbourn approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 30, 2017
@mmalerba mmalerba merged commit 1847819 into angular:master May 30, 2017
@devversion devversion deleted the build/live-reload-theme-scss branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @mmalerba