fix(checkbox): do not set indeterminate when set checked programmatically
#4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Apr 11, 2017
src/lib/checkbox/checkbox.spec.ts
Outdated
| fixture.detectChanges(); | ||
|
|
||
| fixture.whenStable().then(() => { | ||
| fixture.detectChanges(); |
Member
There was a problem hiding this comment.
Are the detectChanges calls necessary after whenStable? Also you may be able to avoid the nesting and the whenStable calls by wrapping the test with fakeAsync, instead of async.
tinayuangao
force-pushed
the
fix-checkbox
branch
from
5caa8ed to
2beb453
Compare
tinayuangao
force-pushed
the
fix-checkbox
branch
from
2beb453 to
9861af9
Compare
crisbeto
approved these changes
Apr 12, 2017
|
|
||
| })); | ||
|
|
||
| it('should not set indeterminate to false when checked is set programmatically', async(() => { |
Member
There was a problem hiding this comment.
You may be able to avoid using async here as well.
jelbourn
reviewed
Apr 13, 2017
| if (this._indeterminate) { | ||
| Promise.resolve().then(() => { | ||
| this._indeterminate = false; | ||
| this.indeterminateChange.emit(this._indeterminate); |
Member
There was a problem hiding this comment.
Can go in a follow-up PR, but this should only emit when the value is different
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indeterminatewhen user manually click on the checkbox