fix(material/dialog): afterOpened emitting too early when animations are disabled #32211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev and
tjshiu
and removed request for
a team
crisbeto
force-pushed
the
32205/dialog-after-opened
branch
from
d2ca0f2 to
921a5bf
Compare
…are disabled Fixes that the `afterOpened` stream was emitting too early when animations are disabled, causing subscriptions triggered by the template to not pick it up. Fixes angular#32205.
crisbeto
force-pushed
the
32205/dialog-after-opened
branch
from
921a5bf to
3e05487
Compare
crisbeto
added
target: rc
tjshiu
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
afterOpenedstream was emitting too early when animations are disabled, causing subscriptions triggered by the template to not pick it up.Fixes #32205.