fix(aria/menu): public api cleanup #32189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Oct 28, 2025
wagnermaciel
commented
- remove onSubmit from MenuTrigger
- rename submenu to menu for MenuTrigger
- defer rendering of menu content
- remove parent input from Menu
- remove submenu input from Menu
- rename onSubmit to onSelect for Menu and MenuBar
- remove onSubmit from MenuTrigger
wagnermaciel
requested review from
crisbeto and
ok7sai
and removed request for
a team
wagnermaciel
added
the
target: minor
crisbeto
approved these changes
Oct 29, 2025
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* fix(aria/menu): remove onSubmit from MenuTrigger * refactor(aria/menu): rename submenu to menu for MenuTrigger * fix(aria/menu): defer rendering of menu content * refactor(aria/menu): remove parent input * refactor(aria/menu): remove submenu input * refactor(aria/menu): rename onSubmit to onSelect * refactor(aria/menu): remove onSelect from MenuTrigger
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* fix(aria/menu): remove onSubmit from MenuTrigger * refactor(aria/menu): rename submenu to menu for MenuTrigger * fix(aria/menu): defer rendering of menu content * refactor(aria/menu): remove parent input * refactor(aria/menu): remove submenu input * refactor(aria/menu): rename onSubmit to onSelect * refactor(aria/menu): remove onSelect from MenuTrigger
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* fix(aria/menu): remove onSubmit from MenuTrigger * refactor(aria/menu): rename submenu to menu for MenuTrigger * fix(aria/menu): defer rendering of menu content * refactor(aria/menu): remove parent input * refactor(aria/menu): remove submenu input * refactor(aria/menu): rename onSubmit to onSelect * refactor(aria/menu): remove onSelect from MenuTrigger
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Nov 3, 2025
* fix(aria/menu): remove onSubmit from MenuTrigger * refactor(aria/menu): rename submenu to menu for MenuTrigger * fix(aria/menu): defer rendering of menu content * refactor(aria/menu): remove parent input * refactor(aria/menu): remove submenu input * refactor(aria/menu): rename onSubmit to onSelect * refactor(aria/menu): remove onSelect from MenuTrigger
wagnermaciel
added a commit
that referenced
this pull request
Nov 3, 2025
* fix(aria/menu): remove onSubmit from MenuTrigger * refactor(aria/menu): rename submenu to menu for MenuTrigger * fix(aria/menu): defer rendering of menu content * refactor(aria/menu): remove parent input * refactor(aria/menu): remove submenu input * refactor(aria/menu): rename onSubmit to onSelect * refactor(aria/menu): remove onSelect from MenuTrigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.