Skip to content

fix(material/menu): add filter for trigger icon name #32188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix(material/menu): add filter for trigger icon name #32188

merged 1 commit into from
Oct 28, 2025
+51 −29

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 28, 2025

Adds the option to filter harnesses based on the icon in the menu trigger.

Fixes #32181.

@crisbeto
fix(material/menu): add filter for trigger icon name
4d9c87c 
Adds the option to filter harnesses based on the icon in the menu trigger.

Fixes angular#32181.
@crisbeto crisbeto requested a review from a team as a code owner October 28, 2025 09:19
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 28, 2025
@crisbeto crisbeto requested review from tjshiu and wagnermaciel and removed request for a team October 28, 2025 09:19
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 28, 2025
@crisbeto crisbeto merged commit c9289b5 into angular:main Oct 28, 2025
27 of 29 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Oct 28, 2025

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Oct 28, 2025
@crisbeto
fix(material/menu): add filter for trigger icon name (#32188)
b751456 
Adds the option to filter harnesses based on the icon in the menu trigger.

Fixes #32181.

(cherry picked from commit c9289b5)
crisbeto added a commit that referenced this pull request Oct 28, 2025
@crisbeto
fix(material/menu): add filter for trigger icon name (#32188)
378f4cf 
Adds the option to filter harnesses based on the icon in the menu trigger.

Fixes #32181.

(cherry picked from commit c9289b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok7sai ok7sai ok7sai approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/menu target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(material/testing): Add trigger icon name filtering to MatMenuHarness

2 participants

@crisbeto @ok7sai