Skip to content

fix(material/timepicker): assign form control value before emitting events #31981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix(material/timepicker): assign form control value before emitting events #31981

merged 1 commit into from
Oct 3, 2025

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 3, 2025

Fixes that we were emitting some events before the form control value was assigned.

Fixes #31950.

@crisbeto
fix(material/timepicker): assign form control value before emitting e…
40cf8e5 
…vents

Fixes that we were emitting some events before the form control value was assigned.

Fixes angular#31950.
@crisbeto crisbeto requested a review from a team as a code owner October 3, 2025 07:04
@crisbeto crisbeto requested review from wagnermaciel and removed request for a team October 3, 2025 07:04
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 3, 2025
@crisbeto crisbeto requested a review from ok7sai October 3, 2025 07:04
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 3, 2025
@crisbeto crisbeto merged commit c848d24 into angular:main Oct 3, 2025
29 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Oct 3, 2025

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Oct 3, 2025
@crisbeto
fix(material/timepicker): assign form control value before emitting e…
de3f9e5 
…vents (#31981)

Fixes that we were emitting some events before the form control value was assigned.

Fixes #31950.

(cherry picked from commit c848d24)
adolgachev pushed a commit to adolgachev/components that referenced this pull request Oct 19, 2025
@crisbeto @adolgachev
fix(material/timepicker): assign form control value before emitting e…
dd3ce12 
…vents (angular#31981)

Fixes that we were emitting some events before the form control value was assigned.

Fixes angular#31950.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 3, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/timepicker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(timepicker): timepicker fire events before updating formControl value

2 participants

@crisbeto @andrewseguin