Skip to content

fix(material/menu): switch internal state to signals #31934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

fix(material/menu): switch internal state to signals #31934

merged 1 commit into from
Sep 29, 2025

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 27, 2025

Switches the _isAnimating state to a signal in order to avoid "changed after checked" errors.

Fixes #31933.

@crisbeto
fix(material/menu): switch internal state to signals
715536a 
Switches the `_isAnimating` state to a signal in order to avoid "changed after checked" errors.

Fixes angular#31933.
@crisbeto crisbeto requested a review from a team as a code owner September 27, 2025 07:31
@crisbeto crisbeto requested review from adolgachev and ok7sai and removed request for a team September 27, 2025 07:31
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 27, 2025
@crisbeto crisbeto mentioned this pull request Sep 27, 2025
Closed
1 task
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 29, 2025
@crisbeto crisbeto merged commit 813f66b into angular:main Sep 29, 2025
26 of 29 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Sep 29, 2025

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Sep 29, 2025
@crisbeto
fix(material/menu): switch internal state to signals (#31934)
a6f0bd8 
Switches the `_isAnimating` state to a signal in order to avoid "changed after checked" errors.

Fixes #31933.

(cherry picked from commit 813f66b)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 30, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/menu target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

2 participants

@crisbeto @mmalerba