fix(material/radio): color tokens excluded when passing in variant #31321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
31319/radio-color-variant
branch
from
9549dc3 to
ae8fe4d
Compare
Fixes that when passing in a variant into the radio button's `get-tokens` function, we were removing the color tokens altogether, because passing in multiple arguments into `map.remove` removes all those keys, rather than removing a nested value. Fixes angular#31319.
crisbeto
force-pushed
the
31319/radio-color-variant
branch
from
ae8fe4d to
9d15f86
Compare
andrewseguin
approved these changes
Jun 10, 2025
|
The changes were merged into the following branches: main, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
Jun 11, 2025
…31321) Fixes that when passing in a variant into the radio button's `get-tokens` function, we were removing the color tokens altogether, because passing in multiple arguments into `map.remove` removes all those keys, rather than removing a nested value. Fixes #31319. (cherry picked from commit 3f7d277)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that when passing in a variant into the radio button's
get-tokensfunction, we were removing the color tokens altogether, because passing in multiple arguments intomap.removeremoves all those keys, rather than removing a nested value.Fixes #31319.