Skip to content

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented May 25, 2025

Converge on using get-theme-color to get theme colors with opacity. The missing piece was that get-theme color wasn't variable-friendly, so now it returns a color-mix if the color is not a "color"

Also, when possible, just use the foreground base color instead of various different colors when passing any opacity

@andrewseguin andrewseguin requested a review from a team as a code owner May 25, 2025 13:08
@andrewseguin andrewseguin requested review from adolgachev and wagnermaciel and removed request for a team May 25, 2025 13:08
@andrewseguin andrewseguin force-pushed the safe-color branch 3 times, most recently from 6a89ef7 to e8c886a Compare May 25, 2025 13:36
@andrewseguin andrewseguin added the target: minor This PR is targeted for the next minor release label May 25, 2025
@andrewseguin andrewseguin requested a review from crisbeto May 25, 2025 13:46
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 26, 2025
@crisbeto crisbeto merged commit 4932b47 into angular:main May 26, 2025
22 of 25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants