fix(material/sidenav): removes -1 tabindex from sidenav #31155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
crisbeto and
andrewseguin
and removed request for
a team
essjay05
added
dev-app preview
|
Deployed dev-app for 13d3e21 to: https://ng-dev-previews-comp--pr-angular-components-31155-dev-0bf1599t.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto
approved these changes
May 20, 2025
Updates Angular Components SideNav component so that when the mode is not equalt to side the tabIndex value is -1. Otherwise provide a null value. Fixes b/286459024
Updates previous fix to use proper syntax to calculate which mode that the sidenav is set to.
essjay05
force-pushed
the
remove-sidenav-side-container-focus
branch
from
865bf9d to
4b5161c
Compare
Updates previous changes to add the reasoning and reference for the removal of the -1 for side mode sidenavs.
andrewseguin
added
target: patch
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
andrewseguin
pushed a commit
that referenced
this pull request
May 20, 2025
* fix(material/sidenav): removes -1 tabindex from sidenav Updates Angular Components SideNav component so that when the mode is not equalt to side the tabIndex value is -1. Otherwise provide a null value. Fixes b/286459024 * refactor(material/sidenav): updates syntax Updates previous fix to use proper syntax to calculate which mode that the sidenav is set to. * refactor(material/sidenav): adds comments to explain reason for change Updates previous changes to add the reasoning and reference for the removal of the -1 for side mode sidenavs. (cherry picked from commit 08a3c04)
andrewseguin
pushed a commit
that referenced
this pull request
May 20, 2025
* fix(material/sidenav): removes -1 tabindex from sidenav Updates Angular Components SideNav component so that when the mode is not equalt to side the tabIndex value is -1. Otherwise provide a null value. Fixes b/286459024 * refactor(material/sidenav): updates syntax Updates previous fix to use proper syntax to calculate which mode that the sidenav is set to. * refactor(material/sidenav): adds comments to explain reason for change Updates previous changes to add the reasoning and reference for the removal of the -1 for side mode sidenavs. (cherry picked from commit 08a3c04)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components SideNav component so that when
the mode is not equalt to side the tabIndex value is -1.
Otherwise provide a null value.
Before fix screenshot
After fix screenshot
After fix screenshot of mat-drawer-end comparison
Fixes b/286459024