test(multiple): switch CDK tests to standalone #31113
Merged
+784
−905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
mmalerba
approved these changes
May 14, 2025
crisbeto
added
action: merge
crisbeto
force-pushed
the
cdk-tests-standalone
branch
from
4f325a1 to
0ac3ae4
Compare
Switches the remaining CDK tests that weren't standalone to standalone. For the `popover-edit` tests specifically I ended up removing the templates that were created using string interpolation, because it made them hard to read and it can be a problem if we start running the tests in AoT.
crisbeto
force-pushed
the
cdk-tests-standalone
branch
from
0ac3ae4 to
efeac3d
Compare
|
The changes were merged into the following branches: main, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
May 14, 2025
Switches the remaining CDK tests that weren't standalone to standalone. For the `popover-edit` tests specifically I ended up removing the templates that were created using string interpolation, because it made them hard to read and it can be a problem if we start running the tests in AoT. (cherry picked from commit 31077c2)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the remaining CDK tests that weren't standalone to standalone.
For the
popover-edittests specifically I ended up removing the templates that were created using string interpolation, because it made them hard to read and it can be a problem if we start running the tests in AoT.