Skip to content

feat(cdk-experimental/ui-patterns): add expansion behavior and refactor tabs #30962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

feat(cdk-experimental/ui-patterns): add expansion behavior and refactor tabs #30962

merged 1 commit into from
May 2, 2025

Conversation

ok7sai
Copy link
Member

@ok7sai ok7sai commented Apr 27, 2025 •
edited
Loading

  • Added expansion behavior that will be used in Accordion pattern later on.
  • Updated Tabs jsdoc.
  • Refactored Tabs to use show-hide behavior

@ok7sai ok7sai requested a review from wagnermaciel April 27, 2025 06:03
@ok7sai ok7sai requested a review from a team as a code owner April 27, 2025 06:03
@ok7sai ok7sai requested review from crisbeto and removed request for a team April 27, 2025 06:03
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 27, 2025
@ok7sai ok7sai force-pushed the show-hide branch 2 times, most recently from 2f71260 to 93c1223 Compare April 27, 2025 06:17
wagnermaciel
wagnermaciel reviewed May 2, 2025
View reviewed changes
wagnermaciel
wagnermaciel reviewed May 2, 2025
View reviewed changes
wagnermaciel
wagnermaciel approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are addressed

@ok7sai ok7sai force-pushed the show-hide branch 2 times, most recently from 8f69da9 to 94bb0cc Compare May 2, 2025 20:45
@ok7sai ok7sai changed the title feat(cdk-experimental/ui-patterns): add show-hide behavior and refactor tabs feat(cdk-experimental/ui-patterns): add expansion behavior and refactor tabs May 2, 2025
@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels May 2, 2025
@ok7sai ok7sai removed the request for review from crisbeto May 2, 2025 23:11
@ok7sai ok7sai merged commit 8be9b8f into angular:main May 2, 2025
32 of 34 checks passed
@ok7sai
Copy link
Member Author

ok7sai commented May 2, 2025

The changes were merged into the following branches: main, 20.0.x

ok7sai added a commit that referenced this pull request May 2, 2025
@ok7sai
feat(cdk-experimental/ui-patterns): add expansion behavior and refact…
1833aa3 
…or tabs (#30962)

(cherry picked from commit 8be9b8f)
wildcardalice pushed a commit to wildcardalice/components that referenced this pull request May 12, 2025
@ok7sai @wildcardalice
feat(cdk-experimental/ui-patterns): add expansion behavior and refact…
20152fd 
…or tabs (angular#30962)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2025
@ok7sai ok7sai deleted the show-hide branch June 16, 2025 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ok7sai @wagnermaciel