Skip to content

Conversation

ok7sai
Copy link
Member

@ok7sai ok7sai commented Apr 24, 2025

No description provided.

@ok7sai ok7sai requested a review from a team as a code owner April 24, 2025 16:25
@ok7sai ok7sai requested review from crisbeto and mmalerba and removed request for a team April 24, 2025 16:25
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 24, 2025
@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 24, 2025
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the entrypoints list here: https://github.com/angular/components/blob/main/src/cdk-experimental/config.bzl#L2 I think that should resolve the lint issue

@ok7sai
Copy link
Member Author

ok7sai commented Apr 24, 2025

can you update the entrypoints list here: https://github.com/angular/components/blob/main/src/cdk-experimental/config.bzl#L2 I think that should resolve the lint issue

I do see "tabs" in the list. Maybe this file? https://github.com/angular/components/blob/main/src/components-examples/config.bzl

@mmalerba
Copy link
Contributor

looks like the bzl file was already updated and I just needed to sync

@ok7sai
Copy link
Member Author

ok7sai commented Apr 24, 2025

Ohh I see. Thanks!

@mmalerba
Copy link
Contributor

ok nvm apparently that's not the source of truth for the commit message check, I think this is the actual file: .ng-dev/commit-message.mts (I updated it for you)

@mmalerba mmalerba requested a review from a team as a code owner April 24, 2025 21:47
@mmalerba mmalerba removed the request for review from a team April 24, 2025 21:48
@mmalerba mmalerba merged commit 025010b into angular:main Apr 24, 2025
21 of 23 checks passed
@ok7sai ok7sai deleted the ng-aria-tabs branch April 24, 2025 21:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants