Skip to content

fix(ripple): fix ripple color in dark theme #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2017
Merged

fix(ripple): fix ripple color in dark theme #3094

merged 1 commit into from
Feb 16, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Feb 14, 2017

  • Fixes the incorrect color for ripple elements in dark-themes.

@devversion
fix(ripple): fix ripple color in dark theme
f611957 
* Fixes the incorrect color for ripple elements in dark-themes.
@devversion devversion requested review from kara and mmalerba February 14, 2017 19:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 14, 2017
kara
kara approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 14, 2017
@kara kara removed their assignment Feb 14, 2017
@andrewseguin andrewseguin merged commit a91ae72 into angular:master Feb 16, 2017
@devversion devversion deleted the fix/ripples-dark-theme branch November 11, 2017 10:19
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion @kara @googlebot @mmalerba @andrewseguin