Skip to content

fix(cdk/schematics): account for new karma builder #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

fix(cdk/schematics): account for new karma builder #30907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/cdk/schematics/utils/project-targets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@
import {JsonValue, workspaces} from '@angular-devkit/core';
import {SchematicsException} from '@angular-devkit/schematics';

/** Possible names of CLI builders used to configure the project. */
const PROJECT_BUILDERS = new Set([
'@angular-devkit/build-angular:browser-esbuild',
'@angular-devkit/build-angular:application',
'@angular-devkit/build-angular:browser',
'@angular/build:application',
]);

/** Possible name of CLI builders used to run tests in the project. */
const TEST_BUILDERS = new Set(['@angular-devkit/build-angular:karma', '@angular/build:karma']);

/** Resolves the architect options for the build target of the given project. */
export function getProjectTargetOptions(
project: workspaces.ProjectDefinition,
Expand All @@ -29,24 +40,14 @@ export function getProjectTargetOptions(
export function getProjectBuildTargets(
project: workspaces.ProjectDefinition,
): workspaces.TargetDefinition[] {
return getTargetsByBuilderName(
project,
builder =>
builder === '@angular-devkit/build-angular:application' ||
builder === '@angular-devkit/build-angular:browser' ||
builder === '@angular-devkit/build-angular:browser-esbuild' ||
builder === '@angular/build:application',
);
return getTargetsByBuilderName(project, builder => !!builder && PROJECT_BUILDERS.has(builder));
}

/** Gets all of the default CLI-provided testing targets in a project. */
export function getProjectTestTargets(
project: workspaces.ProjectDefinition,
): workspaces.TargetDefinition[] {
return getTargetsByBuilderName(
project,
builder => builder === '@angular-devkit/build-angular:karma',
);
return getTargetsByBuilderName(project, builder => !!builder && TEST_BUILDERS.has(builder));
}

/** Gets all targets from the given project that pass a predicate check. */
Expand Down
Loading