Skip to content

fix(cdk-experimental/listbox): change shift+nav behavior #30854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

fix(cdk-experimental/listbox): change shift+nav behavior #30854

merged 3 commits into from
Apr 17, 2025

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@wagnermaciel wagnermaciel added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Apr 11, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

Deployed dev-app for 6f8ce0e to: https://ng-dev-previews-comp--pr-angular-components-30854-dev-7gsw2eis.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@wagnermaciel wagnermaciel force-pushed the listbox-range-selection branch from f4b437f to a40bb1a Compare April 14, 2025 15:00
@wagnermaciel wagnermaciel marked this pull request as ready for review April 14, 2025 19:30
@wagnermaciel wagnermaciel requested a review from a team as a code owner April 14, 2025 19:30
@wagnermaciel wagnermaciel requested review from crisbeto and mmalerba and removed request for a team April 14, 2025 19:30
@wagnermaciel
Copy link
Contributor Author

@mmalerba I think I've come up with a cleaner solution for this. I'm going to try and take another stab at this tomorrow and I'll send for re-review. Sorry for the double-review on this one

@wagnermaciel wagnermaciel force-pushed the listbox-range-selection branch from 5703018 to 0c6b0f5 Compare April 15, 2025 20:33
@wagnermaciel wagnermaciel requested a review from mmalerba April 16, 2025 16:29
@wagnermaciel
Copy link
Contributor Author

@mmalerba Ok, finally got this into a ready state.

Fixing the shift+nav behavior ended up being a can of worms. Let me know if you think this PR has ballooned up too big to review and I'll split it up into smaller chunks.

mmalerba
mmalerba approved these changes Apr 16, 2025
View reviewed changes
@wagnermaciel wagnermaciel force-pushed the listbox-range-selection branch from 905f27f to 004076c Compare April 17, 2025 21:09
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 17, 2025
@wagnermaciel wagnermaciel removed the request for review from crisbeto April 17, 2025 22:07
@wagnermaciel wagnermaciel merged commit e0446ec into angular:main Apr 17, 2025
24 of 26 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagnermaciel @mmalerba