Skip to content

Conversation

andrewseguin
Copy link
Contributor

Color input was checking if a map was provided (primary, tertiary, theme type) but the alternative is a palette, which is also a map. This adds the right nuance.

TODO: Send a PR that adds types to Sass so this can be more intuitive

@andrewseguin andrewseguin requested a review from a team as a code owner October 22, 2024 19:29
@andrewseguin andrewseguin requested review from amysorto and wagnermaciel and removed request for a team October 22, 2024 19:29
@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Oct 22, 2024
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Oct 23, 2024
@andrewseguin andrewseguin removed the request for review from amysorto October 23, 2024 16:02
@andrewseguin andrewseguin merged commit a8e40ec into angular:main Oct 23, 2024
20 of 22 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants