Skip to content

Conversation

@dnlrbz
Copy link
Contributor

@dnlrbz dnlrbz commented Aug 1, 2024

Fix typos in comments and test descriptions, fix query selectors and unresolved variables

@dnlrbz dnlrbz requested a review from a team as a code owner August 1, 2024 15:36
@dnlrbz dnlrbz requested review from crisbeto and mmalerba and removed request for a team August 1, 2024 15:36
<mat-autocomplete #auto="matAutocomplete">
@for (group of stateGroups; track group) {
<mat-optgroup [label]="group.label">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label does not exist in group. There is a title instead.

@dnlrbz dnlrbz force-pushed the refact/fix-typos-and-unresolved-vars branch from 06c660a to be28df7 Compare August 1, 2024 15:43
@dnlrbz dnlrbz changed the title refact(material/autocomplete) fixed typos and unresolved variables in tests fix(material/autocomplete) fixed typos and unresolved variables in tests Aug 1, 2024
@dnlrbz dnlrbz force-pushed the refact/fix-typos-and-unresolved-vars branch from be28df7 to 2839a2c Compare August 1, 2024 15:58
@dnlrbz dnlrbz changed the title fix(material/autocomplete) fixed typos and unresolved variables in tests fix(material/autocomplete) typos and unresolved variables in tests Aug 1, 2024
@dnlrbz dnlrbz force-pushed the refact/fix-typos-and-unresolved-vars branch 4 times, most recently from 177c428 to 27b81af Compare August 1, 2024 16:48
Fix typos in comments and test description, fix query selectors and unresolved variables
@dnlrbz dnlrbz force-pushed the refact/fix-typos-and-unresolved-vars branch from 27b81af to b26ef87 Compare August 1, 2024 16:52
@dnlrbz dnlrbz changed the title fix(material/autocomplete) typos and unresolved variables in tests fix(material/autocomplete): typos and unresolved variables in tests Aug 1, 2024
@crisbeto crisbeto removed the request for review from mmalerba August 9, 2024 12:18
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Aug 9, 2024
@crisbeto crisbeto merged commit df7104f into angular:main Aug 9, 2024
crisbeto pushed a commit that referenced this pull request Aug 9, 2024
…29532)

Fix typos in comments and test description, fix query selectors and unresolved variables

(cherry picked from commit df7104f)
crisbeto pushed a commit that referenced this pull request Aug 9, 2024
…29532)

Fix typos in comments and test description, fix query selectors and unresolved variables

(cherry picked from commit df7104f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants