Skip to content

fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is … #29176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is … #29176

merged 1 commit into from
Jun 4, 2024

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jun 3, 2024

…not present

This commit fixes the harness environment which assumes Zone is always defined on the page.

@atscott atscott force-pushed the testbedharnessenv branch from c539194 to 19322df Compare June 3, 2024 18:02
@atscott
fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is …
1cf4e29 
…not present

This commit fixes the harness environment which assumes Zone is always
defined on the page.
@atscott atscott force-pushed the testbedharnessenv branch from 19322df to 1cf4e29 Compare June 3, 2024 18:09
mmalerba
mmalerba approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 3, 2024
@amysorto amysorto removed the request for review from devversion June 4, 2024 18:05
@amysorto amysorto merged commit f4387fd into angular:main Jun 4, 2024
amysorto pushed a commit that referenced this pull request Jun 4, 2024
@atscott @amysorto
fix(cdk/testing): TestbedHarnessEnvironment should work when Zone is …
5ef11b1 
…not present (#29176)

This commit fixes the harness environment which assumes Zone is always
defined on the page.

(cherry picked from commit f4387fd)
@ambrose40 ambrose40 mentioned this pull request Jun 27, 2024
Open
@Addin Addin mentioned this pull request Jul 1, 2024
Closed
@hantsy hantsy mentioned this pull request Jul 4, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Jul 4, 2024
Open
@sanjayrajesh sanjayrajesh mentioned this pull request Jul 4, 2024
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atscott @mmalerba @amysorto