Skip to content

Conversation

@JoelLefkowitz
Copy link
Contributor

Screenshot 2024-05-22 at 15 04 20

Some comments that get marked up into text on the webapp have grammar mistakes. Usually don't bother with spelling but this one caught my eye :)

@google-cla
Copy link

google-cla bot commented May 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@josephperrott josephperrott removed their request for review May 23, 2024 15:05
@JoelLefkowitz
Copy link
Contributor Author

@mmalerba could you please review again?

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 7, 2024
@andrewseguin
Copy link
Contributor

Thanks for your contribution - can you rebase this PR?

@devversion devversion removed their request for review June 10, 2024 10:42
@JoelLefkowitz JoelLefkowitz requested a review from a team as a code owner July 3, 2024 10:13
@JoelLefkowitz JoelLefkowitz requested review from amysorto and crisbeto and removed request for a team July 3, 2024 10:13
@JoelLefkowitz
Copy link
Contributor Author

Thanks @andrewseguin, rebased it. How can I trigger the google-internal-tests workflow?

@andrewseguin andrewseguin merged commit 168b89e into angular:main Aug 8, 2024
andrewseguin pushed a commit that referenced this pull request Aug 8, 2024
(cherry picked from commit 168b89e)
andrewseguin pushed a commit that referenced this pull request Aug 8, 2024
(cherry picked from commit 168b89e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants