Skip to content

fix(material/divider): non-text color contrast issues #28995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(material/divider): non-text color contrast issues #28995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a77bbf
fix(material/divider): non-text color contrast issues
DBowen33 May 2, 2024
e65e9d9
fix(material/divider): fixed demo list border color
DBowen33 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dev-app/list/list-demo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
flex-flow: row wrap;

.mat-mdc-list-base {
border: 1px solid rgba(0, 0, 0, 0.12);
border: 1px solid var(--mat-divider-color);
width: 350px;
margin: 20px 20px 0 0;
}
Expand Down
2 changes: 1 addition & 1 deletion src/material/core/tokens/m3/mat/_divider.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ $prefix: (mat, divider);
@function get-tokens($systems, $exclude-hardcoded, $token-slots) {
$tokens: (
width: token-utils.hardcode(1px, $exclude-hardcoded),
color: map.get($systems, md-sys-color, outline-variant),
color: map.get($systems, md-sys-color, outline),
);

@return token-utils.namespace-tokens($prefix, $tokens, $token-slots);
Expand Down
2 changes: 1 addition & 1 deletion src/material/core/tokens/m3/mat/_expansion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $prefix: (mat, expansion);
header-indicator-display: token-utils.hardcode(inline-block, $exclude-hardcoded),
container-background-color: map.get($systems, md-sys-color, surface),
container-text-color: map.get($systems, md-sys-color, on-surface),
actions-divider-color: map.get($systems, md-sys-color, outline-variant),
actions-divider-color: map.get($systems, md-sys-color, outline),
header-hover-state-layer-color: sass-utils.safe-color-change(
map.get($systems, md-sys-color, on-surface),
$alpha: map.get($systems, md-sys-state, hover-state-layer-opacity)
Expand Down
2 changes: 1 addition & 1 deletion src/material/core/tokens/m3/mat/_stepper.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ $prefix: (mat, stepper);
$tokens: (
(
container-color: map.get($systems, md-sys-color, surface),
line-color: map.get($systems, md-sys-color, outline-variant),
line-color: map.get($systems, md-sys-color, outline),
header-hover-state-layer-color: sass-utils.safe-color-change(
map.get($systems, md-sys-color, inverse-surface),
$alpha: map.get($systems, md-sys-state, hover-state-layer-opacity)
Expand Down
2 changes: 1 addition & 1 deletion src/material/core/tokens/m3/mat/_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $prefix: (mat, table);
background-color: map.get($systems, md-sys-color, surface),
header-headline-color: map.get($systems, md-sys-color, on-surface),
row-item-label-text-color: map.get($systems, md-sys-color, on-surface),
row-item-outline-color: map.get($systems, md-sys-color, outline-variant),
row-item-outline-color: map.get($systems, md-sys-color, outline),
),
);

Expand Down