Skip to content

fix(material/dialog): mark dialog content as scrollable #28963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix(material/dialog): mark dialog content as scrollable #28963

merged 1 commit into from
Apr 26, 2024

Conversation

crisbeto
Copy link
Member

Adds CdkScrollable to MatDialogContent so that overlays inside of it can reposition on scroll.

Fixes #28936.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 25, 2024
@crisbeto crisbeto requested a review from devversion as a code owner April 25, 2024 07:09
@crisbeto crisbeto mentioned this pull request Apr 25, 2024
Closed
@crisbeto
fix(material/dialog): mark dialog content as scrollable
0ee5cfb 
Adds `CdkScrollable` to `MatDialogContent` so that overlays inside of it can reposition on scroll.

Fixes angular#28936.
@crisbeto crisbeto force-pushed the 28936/dialog-scrollable branch from 52550ae to 0ee5cfb Compare April 25, 2024 07:44
@crisbeto crisbeto self-assigned this Apr 25, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Apr 25, 2024
@crisbeto crisbeto merged commit d0a2d3a into angular:main Apr 26, 2024
crisbeto added a commit that referenced this pull request Apr 26, 2024
@crisbeto
fix(material/dialog): mark dialog content as scrollable (#28963)
6dc8f7e 
Adds `CdkScrollable` to `MatDialogContent` so that overlays inside of it can reposition on scroll.

Fixes #28936.

(cherry picked from commit d0a2d3a)
@Sergiobop Sergiobop mentioned this pull request Apr 27, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(AUTOCOMPLETE): Autocomplete options popup is not binded to its target element when dialog is scrolled
2 participants
@crisbeto @andrewseguin