feat(multiple): token overrides api #28910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Apr 18, 2024
wagnermaciel
commented
- Roll out the overrides api to provide users with a well-lit path for overriding our css variables.
* Roll out the overrides api to provide users with a well-lit path for overriding our css variables.
wagnermaciel
requested review from
crisbeto,
andrewseguin,
devversion,
jelbourn,
mmalerba and
zarend
as code owners
crisbeto
reviewed
Apr 19, 2024
| } | ||
| } | ||
|
|
||
| @mixin overrides($tokens: ()) { |
There was a problem hiding this comment.
- We should expose these in the
_index.scss, otherwise they're not usable. - Should we document this somewhere?
There was a problem hiding this comment.
Added the mixins to _index.scss. I can add a section on our theming.md, but should that be done in a follow-up PR or as part of this PR?
There was a problem hiding this comment.
I'm fine with doing the docs in a follow-up.
crisbeto
approved these changes
Apr 19, 2024
wagnermaciel
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.