Skip to content

Conversation

wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Mar 21, 2024

…ox tokens

Example usage:

.html {
  @include mat.checkbox-overrides((
    selected-focus-state-layer-color: blue,
    selected-hover-state-layer-color: blue,
    selected-pressed-state-layer-color: blue,
  ));
}

Notes about the API:

  • An error is thrown if a user passes in a token that does not exist in either the m2/mat or m2/mdc.
  • Prefixes are determined automagically for the user based on whether the token exists in the m2/mat or m2/mdc tokens.

@wagnermaciel wagnermaciel requested a review from mmalerba as a code owner March 21, 2024 15:03
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 21, 2024
@wagnermaciel wagnermaciel requested a review from jelbourn as a code owner March 21, 2024 15:16
@wagnermaciel wagnermaciel requested a review from crisbeto March 21, 2024 17:51
@LaySoe
Copy link

LaySoe commented Mar 22, 2024

Thankfully service

@angular angular deleted a comment from LaySoe Mar 22, 2024
@wagnermaciel
Copy link
Contributor Author

@LaySoe The Angular team does not allow links to untrusted files

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we could bikeshed the name "customizations" which I think is pretty lengthy, but I dont have a particularly strong opinion against it, or any radically better suggestions

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 26, 2024
@wagnermaciel wagnermaciel added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 26, 2024
@wagnermaciel wagnermaciel merged commit c345df7 into angular:main Mar 26, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants