fix(material/tabs): prevent page scroll on space press #28532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a regression from angular#27862 where the `preventDefault` was removed both from space and enter presses. We still need it on space so that the page doesn't scroll. Fixes angular#28392.
andrewseguin
approved these changes
Feb 8, 2024
crisbeto
added a commit
that referenced
this pull request
Feb 8, 2024
crisbeto
added a commit
that referenced
this pull request
Feb 8, 2024
|
@crisbeto where do I see with which version this fix will be released? I checked the release notes but haven't found it.. |
Member
Author
|
It should be in the 17.2.0 release. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a regression from #27862 where the
preventDefaultwas removed both from space and enter presses. We still need it on space so that the page doesn't scroll.Fixes #28392.