fix(material/button-toggle): use radio pattern for single select Mat toggle button group #28505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clamli
changed the title
clamli
force-pushed
the
mat-button-toggle-group
branch
2 times, most recently
from
fcd8a94 to
5c845a3
Compare
clamli
force-pushed
the
mat-button-toggle-group
branch
from
5c845a3 to
98eb273
Compare
zarend
added
the
dev-app preview
|
Deployed dev-app for 119797c to: https://ng-dev-previews-comp--pr-angular-components-28505-dev-r8qalkt6.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
clamli
force-pushed
the
mat-button-toggle-group
branch
2 times, most recently
from
644acdd to
3f7ccba
Compare
…toggle button group
clamli
force-pushed
the
mat-button-toggle-group
branch
from
3f7ccba to
119797c
Compare
|
We're considering using a different approach to make it easier to land, see #28548 |
|
Given that #28548 was merged, I'm assuming that we can close this PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the single-select Mat toggle button group to use radio pattern. This way the exclusiveness of the selection can be conveyed to the screen reader users.