Skip to content

Conversation

@mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba requested a review from tinayuangao January 25, 2017 23:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2017
@tinayuangao
Copy link
Contributor

LGTM

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 25, 2017
@mmalerba
Copy link
Contributor Author

fixes #2674

@andrewseguin andrewseguin merged commit 2bd607c into angular:master Jan 26, 2017
@andrewseguin
Copy link
Contributor

Was this to match a closer spec to material design? I haven't seen an example of a persistent sidenav that doesn't have any depth/border to it. I don't think this looks as nice as before. I think mat-elevation-16 was overkill but I'd recommend putting in at least mat-elevation-2.

@mmalerba
Copy link
Contributor Author

@andrewseguin yes this was to match the spec: https://material.io/guidelines/patterns/navigation-drawer.html#navigation-drawer-behavior no reason you can't just add the elevation class in your app though

@mmalerba mmalerba deleted the snav branch February 11, 2017 00:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants