Skip to content

build: exclude system-config-spec.ts for releases #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2017
Merged

build: exclude system-config-spec.ts for releases #2754

merged 1 commit into from
Jan 24, 2017

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 22, 2017

  • No longer publishes the system-config-spec.ts file in releases.

Extending the glob to also remove the -spec.ts files. In the future it's planned to not build spec files for releases at all..

@devversion
build: exclude system-config-spec.ts for releases
c8d4e80 
* No longer publishes the `system-config-spec.ts` file in releases. Extending the glob to also remove the `-spec.ts` files.
  In the future it's planned to not build spec files for releases at all..
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 22, 2017
jelbourn
jelbourn approved these changes Jan 23, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 23, 2017
@andrewseguin andrewseguin merged commit 71c6829 into angular:master Jan 24, 2017
@devversion devversion deleted the build/exclude-config-spec-ts branch January 25, 2017 16:09
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @andrewseguin