build: fix sourcemaps for dev-app and e2e-app. #2753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the invalid sourcemaps for the dev-app and e2e-app. > The sourcemaps didn't include the content of the source file because the paths were mapped incorrectly (due to a combination of `outDir` and `mapRoot`)
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jan 25, 2017
* No longer use the `gulp-typescript` gulp package that tries to take care of several options like `sourceMaps` or `declarations`. * Don't generate declarations when serving the `demo-app`. (Slows down testing) Advantages: * Use the `Typescript` compiler CLI to ensure that the `NGC` also works with our `tsconfig.json` files. * No longer makes our TypeScript build dependent to an external plugin (~with magic) * Fixes issues like invalid sourceMaps from `gulp-typescript`: angular#2753 * Allows us to take use of all TypeScript features (e.g forbidden features in `gulp-typescript) * This should help for our planned `tsconfig.json` file reduction.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the invalid sourcemaps for the dev-app and e2e-app.
The sourcemaps are currently invalid because the
sourcesContentcouldn't be read due to invalid paths.This issue is now noticeable because
gulp-typescriptmade some changes in regards to the sourcemaps. (See here)