Skip to content

feat(autocomplete): add screenreader support #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2017
Merged

feat(autocomplete): add screenreader support #2729

merged 1 commit into from
Jan 23, 2017

Conversation

@kara
Copy link
Contributor

@kara kara commented Jan 20, 2017

I don't know how I accidentally closed this. Reopening.

@kara kara requested review from andrewseguin and jelbourn January 20, 2017 02:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2017
@kara kara force-pushed the autocomplete-aria branch from e9759ab to 70e249a Compare January 23, 2017 20:03
andrewseguin
andrewseguin approved these changes Jan 23, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 23, 2017
@kara kara force-pushed the autocomplete-aria branch from 70e249a to 176a489 Compare January 23, 2017 20:22
@kara kara merged commit 4ad8b82 into angular:autocomplete Jan 23, 2017
kara added a commit to kara/material2 that referenced this pull request Jan 25, 2017
@kara
feat(autocomplete): add screenreader support (angular#2729)
e835895
kara added a commit that referenced this pull request Jan 25, 2017
@kara
feat(autocomplete): add screenreader support (#2729)
e7d528b
kara added a commit to kara/material2 that referenced this pull request Feb 3, 2017
@kara
feat(autocomplete): add screenreader support (angular#2729)
975adf1
kara added a commit to kara/material2 that referenced this pull request Feb 3, 2017
@kara
feat(autocomplete): add screenreader support (angular#2729)
e60d6bb
kara added a commit that referenced this pull request Feb 3, 2017
@kara
feat(autocomplete): add screenreader support (#2729)
bd7f240
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kara @andrewseguin @jelbourn @googlebot