feat(cdk/tree): implement typeahead for TreeKeyManager #26587
Closed
+352
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
from
440ca4e to
deb1f37
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
6 times, most recently
from
85030e9 to
2896fb1
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
from
2896fb1 to
a934a06
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
5 times, most recently
from
30b53fa to
6e5cae2
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
3 times, most recently
from
9600ab8 to
fffb810
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
from
fffb810 to
1fdcee4
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
2 times, most recently
from
e35a828 to
202eb6b
Compare
Collaborator
Author
|
I think I fixed the tests; failing ones seem to be unrelated? |
Member
|
Yes, can you just rebase to make sure it's not related to your PR? the |
Collaborator
Author
|
I'll need someone to rebase the cdk-tree-revamp branch, I don't have the ability to do that |
andrewseguin
force-pushed
the
cdk-tree-revamp
branch
from
ef8a166 to
efbfeee
Compare
BobobUnicorn
force-pushed
the
cdk-tree-a11y-typeahead
branch
from
3eed156 to
04b0637
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26586. Followed by #26588.