Skip to content

docs: fix invalid SCSS in migration guide #26298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

docs: fix invalid SCSS in migration guide #26298

merged 1 commit into from
Dec 20, 2022

Conversation

json-derulo
Copy link
Contributor

@json-derulo json-derulo commented Dec 20, 2022 •
edited
Loading

Fixes an invalid usage of the legacy SCSS module system in the migration guide.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 20, 2022
devversion
devversion approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thx & nice name!

@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 20, 2022
@devversion devversion merged commit 6f37c70 into angular:main Dec 20, 2022
devversion pushed a commit that referenced this pull request Dec 20, 2022
@json-derulo @devversion
docs: fix invalid SCSS in migration guide (#26298)
1df73fb 
(cherry picked from commit 6f37c70)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 20, 2023
@json-derulo json-derulo deleted the docs/migration-guide-scss-use branch January 21, 2023 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@json-derulo @devversion