Skip to content

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Dec 2, 2022

  • Remove stale README that describes the component as experimental
  • Add docs describing the extended fab variant
  • Add aria-labels to button examples that don't have text
  • Remove "basic" color fabs from example, since fab doesn't support an un-colored style (It probably should as its shown in the spec, but that's outside the scope of this docs fix).
  • Add extended fab row to example

Fixes #19058

@mmalerba mmalerba added docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Dec 2, 2022
@mmalerba mmalerba self-assigned this Dec 2, 2022
- Remove stale README that describes the component as experimental
- Add docs describing the extended fab variant
- Add aria-labels to button examples that don't have text
- Remove "basic" color fabs from example, since fab doesn't support an un-colored style
  (It probably should as its shown in the spec, but that's outside the
  scope of this docs fix).
- Add extended fab row to example
@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 2, 2022
@mmalerba mmalerba requested review from crisbeto and wagnermaciel and removed request for andrewseguin December 2, 2022 23:07
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Dec 4, 2022
@mmalerba mmalerba merged commit 2629047 into angular:main Dec 4, 2022
mmalerba added a commit that referenced this pull request Dec 4, 2022
* docs(material/button): improve button docs & examples

- Remove stale README that describes the component as experimental
- Add docs describing the extended fab variant
- Add aria-labels to button examples that don't have text
- Remove "basic" color fabs from example, since fab doesn't support an un-colored style
  (It probably should as its shown in the spec, but that's outside the
  scope of this docs fix).
- Add extended fab row to example

* fixup! docs(material/button): improve button docs & examples

(cherry picked from commit 2629047)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Dec 9, 2022
* docs(material/button): improve button docs & examples

- Remove stale README that describes the component as experimental
- Add docs describing the extended fab variant
- Add aria-labels to button examples that don't have text
- Remove "basic" color fabs from example, since fab doesn't support an un-colored style
  (It probably should as its shown in the spec, but that's outside the
  scope of this docs fix).
- Add extended fab row to example

* fixup! docs(material/button): improve button docs & examples
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug([button mat-fab]): Button Circle doesn't grow with text
2 participants