Skip to content

fix(material/toolbar): inherit toolbar color in flat buttons #26089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix(material/toolbar): inherit toolbar color in flat buttons #26089

merged 1 commit into from
Nov 28, 2022

Conversation

crisbeto
Copy link
Member

Fixes that MDC-based buttons placed inside a toolbar weren't inheriting its text color like the non-MDC buttons.

Fixes #26063.

@crisbeto
fix(material/toolbar): inherit toolbar color in flat buttons
ea1de64 
Fixes that MDC-based buttons placed inside a toolbar weren't inheriting its text color like the non-MDC buttons.

Fixes angular#26063.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 25, 2022
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 28, 2022
@crisbeto crisbeto merged commit 3fb1fbc into angular:main Nov 28, 2022
crisbeto added a commit that referenced this pull request Nov 28, 2022
@crisbeto
fix(material/toolbar): inherit toolbar color in flat buttons (#26089)
c70875d 
Fixes that MDC-based buttons placed inside a toolbar weren't inheriting its text color like the non-MDC buttons.

Fixes #26063.

(cherry picked from commit 3fb1fbc)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 8, 2022
@crisbeto
fix(material/toolbar): don't override colors of themed buttons
0d77fec 
Fixes a regression caused by angular#26089 where the colors of all buttons in the toolbar were being overridden, instead of only the unthemed ones.

Fixes angular#26192.
@crisbeto crisbeto mentioned this pull request Dec 9, 2022
Merged
crisbeto added a commit that referenced this pull request Dec 13, 2022
@crisbeto
fix(material/toolbar): don't override colors of themed buttons (#26222)
e19addb 
Fixes a regression caused by #26089 where the colors of all buttons in the toolbar were being overridden, instead of only the unthemed ones.

Fixes #26192.
crisbeto added a commit that referenced this pull request Dec 13, 2022
@crisbeto
fix(material/toolbar): don't override colors of themed buttons (#26222)
0ca8c77 
Fixes a regression caused by #26089 where the colors of all buttons in the toolbar were being overridden, instead of only the unthemed ones.

Fixes #26192.

(cherry picked from commit e19addb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

@devversion devversion Awaiting requested review from devversion

1 more reviewer

@amysorto amysorto amysorto approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(button): mat-buttons in toolbar don't use toolbars text color
2 participants
@crisbeto @amysorto