Skip to content

fix(material/core): icons not aligned inside mat-option #26054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix(material/core): icons not aligned inside mat-option #26054

merged 1 commit into from
Nov 30, 2022

Conversation

crisbeto
Copy link
Member

Fixes that icons projected inside an MDC-based mat-option weren't centered and didn't have the correct margin like the non-MDC version.

Fixes #26024.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 22, 2022
@crisbeto crisbeto requested a review from mmalerba November 22, 2022 10:06
@crisbeto crisbeto force-pushed the 26024/option-icon branch 2 times, most recently from ff8988e to d260206 Compare November 23, 2022 08:04
@crisbeto
fix(material/core): icons not aligned inside mat-option
e46683a 
Fixes that icons projected inside an MDC-based `mat-option` weren't centered and didn't have the correct margin like the non-MDC version.

Fixes angular#26024.
mmalerba
mmalerba approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 23, 2022
@crisbeto crisbeto merged commit c1a90c4 into angular:main Nov 30, 2022
crisbeto added a commit that referenced this pull request Nov 30, 2022
@crisbeto
fix(material/core): icons not aligned inside mat-option (#26054)
a779d21 
Fixes that icons projected inside an MDC-based `mat-option` weren't centered and didn't have the correct margin like the non-MDC version.

Fixes #26024.

(cherry picked from commit c1a90c4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(autocomplete/select): Icons inside mat-option no longer vertically aligned
2 participants
@crisbeto @mmalerba