Skip to content

fix(material/schematics): not migrating elements with template directives #25956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix(material/schematics): not migrating elements with template directives #25956

merged 1 commit into from
Nov 11, 2022

Conversation

crisbeto
Copy link
Member

The MDC migration wasn't traversing into template elements which meant that it wouldn't migrate elements with an *ngIf or an *ngFor on them.

Fixes #25824.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: rc This PR is targeted for the next release-candidate labels Nov 11, 2022
@crisbeto
fix(material/schematics): not migrating elements with template direct…
73d5151 
…ives

The MDC migration wasn't traversing into template elements which meant that it wouldn't migrate elements with an `*ngIf` or an `*ngFor` on them.

Fixes angular#25824.
@crisbeto crisbeto force-pushed the templates-migration branch from 3dde3e3 to 73d5151 Compare November 11, 2022 08:24
devversion
devversion approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good to see this reflected in the integration golden too

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 11, 2022
@crisbeto crisbeto merged commit 952cf06 into angular:main Nov 11, 2022
crisbeto added a commit that referenced this pull request Nov 11, 2022
@crisbeto
fix(material/schematics): not migrating elements with template direct…
08f6ef4 
…ives (#25956)

The MDC migration wasn't traversing into template elements which meant that it wouldn't migrate elements with an `*ngIf` or an `*ngFor` on them.

Fixes #25824.

(cherry picked from commit 952cf06)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

@mmalerba mmalerba Awaiting requested review from mmalerba

@amysorto amysorto Awaiting requested review from amysorto

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(MDC-MIGRATION): Handle selectable MatChip

2 participants

@crisbeto @devversion