Skip to content

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 5, 2017

  • In gulp-typescript ~3.0.0 the typescript will be no longer included as a dependency.

This means that it now automatically detects the current installed typescript version.

See http://dev.ivogabe.com/gulp-typescript-3/ - Follow-up to #2456 (comment)

* In gulp-typescript ~3.0.0 the `typescript` will be no longer included as a dependency. This means that it now automatically detects the current installed `typescript` version.
  See http://dev.ivogabe.com/gulp-typescript-3/
@devversion devversion requested a review from jelbourn January 5, 2017 00:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 5, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 5, 2017
@devversion
Copy link
Member Author

@jelbourn Nearly instant reviewed (~30 sec)

@jelbourn
Copy link
Member

jelbourn commented Jan 5, 2017

@devversion why are you still awake?

@devversion
Copy link
Member Author

devversion commented Jan 5, 2017

@jelbourn Ehm, I was working on a presentation for school next week (and this is my good-night PR) 😄

@kara kara merged commit eec3108 into angular:master Jan 6, 2017
@devversion devversion deleted the chore/gulp-typescript-peer branch January 6, 2017 11:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants