Skip to content

refactor(material-experimental/mdc-list): remove usage of MDC adapter #24994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

refactor(material-experimental/mdc-list): remove usage of MDC adapter #24994

merged 1 commit into from
May 30, 2022

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented May 30, 2022

Reworks our list not to use MDC's adapters.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels May 30, 2022
@crisbeto crisbeto force-pushed the mdc-list-no-adapter branch from 6c36f8f to 3f3dd0d Compare May 30, 2022 11:28
devversion
devversion approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we didn't seem to use a lot of the MDC foundation anyway.

@crisbeto crisbeto self-assigned this May 30, 2022
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 30, 2022
@crisbeto crisbeto merged commit d74f86f into angular:main May 30, 2022
crisbeto added a commit that referenced this pull request May 30, 2022
@crisbeto
refactor(material-experimental/mdc-list): remove usage of MDC adapter (…
1ac1f83 
…#24994)

Reworks our list not to use MDC's adapters.

(cherry picked from commit d74f86f)
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 7, 2022
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 30, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @devversion