test(multiple): enable easy extension of harnesses #24878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the capability to extend a harness without having to duplicate the `with` method used to load it. This was necessary before because the returned predicate was of type the parent harness which resultet in loading a harness instance of the parent type instead of the derived class unless the method is overridden.
dobrevad
requested review from
andrewseguin,
crisbeto,
devversion and
mmalerba
as code owners
crisbeto
added
P3
|
Commit message fixup: should be a |
devversion
approved these changes
May 5, 2022
crisbeto
pushed a commit
that referenced
this pull request
May 5, 2022
Add the capability to extend a harness without having to duplicate the `with` method used to load it. This was necessary before because the returned predicate was of type the parent harness which resultet in loading a harness instance of the parent type instead of the derived class unless the method is overridden. (cherry picked from commit 14694c8)
This was referenced May 29, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the capability to extend a harness without having to duplicate the
withmethodused to load it. This was necessary before because the returned predicate was of type
the parent harness which resulted in loading a harness instance of the parent type
instead of the derived class unless the method is overridden.