feat(google-maps): switch to non-deprecated API for clustering #24853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
blocked
Member
Author
|
Blocked on the new API being available in g3 and existing users being migrated. |
crisbeto
force-pushed
the
clusterer-rewrite
branch
from
28eff59 to
cb2105c
Compare
The marker clusterer component is currently based on the `@googlemaps/markerclustererplus` package which is deprecated. These changes rewrite the component to use `@googlemaps/markerclusterer` instead. BREAKING CHANGE: The new `@googlemaps/markerclusterer` API should be imported instead of the old one. Read more at: https://github.com/googlemaps/js-markerclusterer Furthermore, the new clustering package doesn't offer the same set of public APIs. As a result, the following inputs to the `MapMarkerClusterer` component have been removed: * `ariaLabelFn` * `averageCenter` * `batchSizeIE` * `calculator` * `clusterClass` * `enableRetinaIcons` * `gridSize` * `ignoreHidden` * `imageExtension` * `imagePath` * `imageSizes` * `maxZoom` * `minimumClusterSize` * `styles` * `title` * `zIndex` * `zoomOnClick` * `options` It is now recommended to customize the cluster using the `renderer` and `algorithm` inputs. Fixes angular#23695.
crisbeto
force-pushed
the
clusterer-rewrite
branch
from
cb2105c to
21405f4
Compare
1 task
josephperrott
added
detected: breaking change
Contributor
|
This was marked to be released in v15 but it looks like it didn't make it. |
|
any update on this @crisbeto ? |
|
@crisbeto Google forcing the use of an API that Google deprecated years ago is not a good look. Isn't it time this one was actioned? |
|
Hi guys, any updates on this PR ? Do we have a potential timeline of when this will land? |
Member
Author
|
Closing in favor of #29885. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marker clusterer component is currently based on the
@googlemaps/markerclustererpluspackage which is deprecated. These changes rewrite the component to use@googlemaps/markerclustererinstead.BREAKING CHANGE:
The new
@googlemaps/markerclustererAPI should be imported instead of the old one. Read more at: https://github.com/googlemaps/js-markerclustererFurthermore, the new clustering package doesn't offer the same set of public APIs. As a result, the following inputs to the
MapMarkerClusterercomponent have been removed:ariaLabelFnaverageCenterbatchSizeIEcalculatorclusterClassenableRetinaIconsgridSizeignoreHiddenimageExtensionimagePathimageSizesmaxZoomminimumClusterSizestylestitlezIndexzoomOnClickoptionsIt is now recommended to customize the cluster using the
rendererandalgorithminputs.Fixes #23695.