fix(cdk/portal): prevent calling ApplicationRef.detachView on destroyed instance
#24775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyed instance This commit adds a check that ensures that the `ApplicationRef.detachView` is only called when there are some registered views in the `ApplicationRef` instance (thus the instance is not destroyed).
AndrewKushnir
added
target: patch
andrewseguin
approved these changes
Apr 14, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 25, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.3/13.3.4) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.3` -> `13.3.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.3/13.3.4) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1334-adamantium-albatross-2022-04-20) [Compare Source](angular/components@13.3.3...13.3.4) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [eef47579f](angular/components@eef4757) | fix | **portal:** prevent calling `ApplicationRef.detachView` on destroyed instance ([#​24775](angular/components#24775)) | #### Special Thanks Andrew Kushnir, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1315 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced Apr 28, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check that ensures that the
ApplicationRef.detachViewis only called when there are some registered views in theApplicationRefinstance (thus the instance is not destroyed).Calling
ApplicationRefAPIs on destroyed instance will result in an error after angular/angular#45624. This commit makes the code forward-compatible with the upcoming changes. The error was discovered in g3 while running a TGP for angular/angular#45624.