fix(material/list): wrong order of arguments when calling custom compareWith function #24743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…areWith function Fixes a bug in Angular Material `selection-list` component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption. Expected order based on documentation is: 1. value of the respective option 2. value of the selection
pweyrich
requested review from
andrewseguin,
crisbeto and
devversion
as code owners
devversion
reviewed
Apr 7, 2022
Good point. I'll take care of it. |
…lling custom compareWith function Fixes a bug in Angular Material's experimental mdc-selection-list component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption. Expected order based on documentation is: 1. value of the respective option 2. value of the selection
@devversion done. |
devversion
approved these changes
Apr 7, 2022
devversion
added
target: patch
amysorto
added
target: patch
amysorto
pushed a commit
that referenced
this pull request
Apr 12, 2022
…areWith function (#24743) * fix(material/list): wrong order of arguments when calling custom compareWith function Fixes a bug in Angular Material `selection-list` component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption. Expected order based on documentation is: 1. value of the respective option 2. value of the selection * fix(material-experimental/mdc-list): wrong order of arguments when calling custom compareWith function Fixes a bug in Angular Material's experimental mdc-selection-list component where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption. Expected order based on documentation is: 1. value of the respective option 2. value of the selection (cherry picked from commit fa12442)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 19, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.2/13.3.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.2` -> `13.3.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.2/13.3.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1333-tweed-table-2022-04-13) [Compare Source](angular/components@13.3.2...13.3.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [949e3c7fbc](angular/components@949e3c7) | fix | **a11y:** visually hidden element affecting scrolling ([#​24620](angular/components#24620)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [1e010a3624](angular/components@1e010a3) | fix | **checkbox:** add the boolean property coercion for checked input ([#​20645](angular/components#20645)) | | [6c65b1d703](angular/components@6c65b1d) | fix | **chips:** prevent default behavior on remove button ([#​24722](angular/components#24722)) | | [4501b2518d](angular/components@4501b25) | fix | **datepicker:** avoid rerender when min/maxDate changes to different time on the same day ([#​24434](angular/components#24434)) | | [aae60833eb](angular/components@aae6083) | fix | **list:** wrong order of arguments when calling custom compareWith function ([#​24743](angular/components#24743)) | | [68c5e870bd](angular/components@68c5e87) | fix | **select:** empty space read out by VoiceOver on Chrome ([#​24741](angular/components#24741)) | | [0d1755d566](angular/components@0d1755d) | fix | **snack-bar:** update generic types for openFromComponent ([#​24634](angular/components#24634)) | | [b83d225b33](angular/components@b83d225) | fix | **tabs:** wrong scroll distance if selected tab is removed ([#​24118](angular/components#24118)) | | [ca30f426a9](angular/components@ca30f42) | perf | **progress-bar:** do not run change detection if there are no `animationEnd` listeners ([#​24673](angular/components#24673)) | #### Special Thanks Artur Androsovych, Georgian Stan, Klemen Oslaj, Kristiyan Kostadinov, Michael Doner, Pascal Weyrich, Paul Gschwendtner, RobStrader and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1306 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced Apr 22, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in Angular Material
selection-listcomponent where the order of arguments passed to a custom compareWith function was mixed up during initialization of a MatListOption.Expected order based on documentation is: