build: add lint rule to disallow type-only imports/exports #24678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type-only imports and exports don't work with Closure so we can't use them.
crisbeto
added
P3
devversion
approved these changes
Mar 27, 2022
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. If this is something we want to use in FW as well, we can consider moving it to dev-infra's set of tslint rules.
(although this is obviously a super short rule)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…4678) Type-only imports and exports don't work with Closure so we can't use them.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-only imports and exports don't work with Closure so we can't use them.