Skip to content

feat(cdk/tree): improve aria attributes #24658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Apr 13, 2023
Merged

feat(cdk/tree): improve aria attributes #24658

merged 37 commits into from
Apr 13, 2023

Conversation

@BobobUnicorn
Copy link
Collaborator

@BobobUnicorn BobobUnicorn commented Mar 24, 2022 •
edited
Loading

Based on #26585. Followed by #24659.

@andrewseguin andrewseguin self-assigned this Apr 21, 2022
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y branch 2 times, most recently from 3b1be6b to 8389cff Compare May 18, 2022 19:41
andrewseguin
andrewseguin reviewed Oct 14, 2022
View reviewed changes
src/cdk/tree/control/base-tree-control.ts Outdated
* Base tree control. It has basic toggle/expand/collapse operations on a single data node.
*
* @deprecated Use one of levelAccessor or childrenAccessor
* @breaking-change 14.0.0
Copy link
Contributor

@andrewseguin andrewseguin Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to leave a placeholder for these breaking changes version markers to make sure they are updated when merged to main

Copy link
Collaborator Author

@BobobUnicorn BobobUnicorn Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

...examples/cdk/tree/cdk-tree-flat-children-accessor/cdk-tree-flat-children-accessor-example.ts Outdated
import {mapTo} from 'rxjs/operators';
import {NestedFoodNode, NESTED_DATA} from '../tree-data';

function* allNodes(nodes: NestedFoodNode[]): Iterable<NestedFoodNode> {
Copy link
Contributor

@andrewseguin andrewseguin Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid creating a generator for the example? This would be too advanced to introduce in an example

Copy link
Collaborator Author

@BobobUnicorn BobobUnicorn Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

This was referenced Feb 7, 2023
Closed
Merged
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y branch 4 times, most recently from 42351e4 to 088a314 Compare February 17, 2023 19:16
@BobobUnicorn
feat(cdk/tree): add demos to the dev-app
7c4c7dc
@BobobUnicorn
feat(cdk/tree): add flat-node with levelAccessor example to the demo
7835cdb 
page
@BobobUnicorn
feat(cdk/tree): move new demos to cdk-tree-redesign dir
25cde66
@BobobUnicorn
fix(cdk/tree): fix unused error
06d47b0
@BobobUnicorn
feat(cdk/tree): move demos back to their own dirs
66185a3
@BobobUnicorn
fix(cdk/tree): address review comments
cb105ae
@BobobUnicorn
feat(cdk/tree): use _getDirectChildren method in nested node
df29768
@BobobUnicorn
feat(cdk/tree): add cache of nodes to the tree
3bbe6dd
@BobobUnicorn
fix(cdk/tree): fix cherry-pick errors
c1025ec
@BobobUnicorn
feat(cdk/tree): add translation layer for nested nodes using levelAcc…
0befab7 
…essor
@BobobUnicorn
feat(cdk/tree): add example with nested nodes & level accessor
3be6e7c
@BobobUnicorn
feat(cdk/tree): fix examples
015aef9
@BobobUnicorn
feat(cdk/tree): add example with flat nodes & childrenAccessor
4d60467
@BobobUnicorn
feat(cdk/tree): flatten data that uses childrenAccessor
1bb07d1
@BobobUnicorn BobobUnicorn force-pushed the cdk-tree-a11y branch 2 times, most recently from fbacbf3 to d37541b Compare February 17, 2023 22:00
@andrewseguin andrewseguin force-pushed the cdk-tree-revamp branch 2 times, most recently from 565eb38 to fbe321d Compare April 4, 2023 21:45
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 5, 2023
@andrewseguin
Copy link
Contributor

andrewseguin commented Apr 6, 2023

Rebase and probably run yarn bazel run //tools/public_api_guard:cdk/tree.md_api.accept

@andrewseguin
Copy link
Contributor

andrewseguin commented Apr 12, 2023

Looks like its just blocked on a small lint issue with breaking-change

@BobobUnicorn
Copy link
Collaborator Author

BobobUnicorn commented Apr 12, 2023

not really sure what's going on with the tests, I'll take a look tomorrow

@andrewseguin
Copy link
Contributor

andrewseguin commented Apr 12, 2023

They seem unrelated to me, we can merge this one

@BobobUnicorn BobobUnicorn marked this pull request as ready for review April 13, 2023 16:14
@BobobUnicorn BobobUnicorn requested a review from jelbourn as a code owner April 13, 2023 16:14
@andrewseguin andrewseguin merged commit 9d95e25 into angular:cdk-tree-revamp Apr 13, 2023
@BobobUnicorn
Copy link
Collaborator Author

BobobUnicorn commented Apr 13, 2023

thanks! I'll prune the PRs that this one subsumes & rebase the rest

@BobobUnicorn BobobUnicorn deleted the cdk-tree-a11y branch April 13, 2023 20:29
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 14, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin left review comments

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees

@andrewseguin andrewseguin

Labels

detected: feature PR contains a feature commit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BobobUnicorn @andrewseguin