Skip to content

Conversation

@zarend
Copy link
Contributor

@zarend zarend commented Mar 21, 2022

Fix issue #24230 in the Datepicker Views Selection code demo. When selecting a month, set the year
on the form value to the active year on the datepicker.

Previously, this demo would only set the year when clicking on a year in the datepicker, but this
did not account for changing the year with the next/previous year buttons.

Fixes #24230

Fix issue angular#24230 in the Datepicker Views Selection code demo. When selecting a month, set the year
on the form value to the active year on the datepicker.

Previously, this demo would only set the year when clicking on a year in the datepicker, but this
did not account for changing the year with the next/previous year buttons.

Fixes angular#24230
@zarend zarend added docs This issue is related to documentation target: patch This PR is targeted for the next patch release area: material/datepicker labels Mar 21, 2022
@zarend zarend requested a review from andrewseguin as a code owner March 21, 2022 22:00
@zarend zarend requested review from crisbeto and mmalerba March 22, 2022 21:06
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 24, 2022
@andrewseguin andrewseguin merged commit c8d9125 into angular:master Mar 24, 2022
andrewseguin pushed a commit that referenced this pull request Mar 24, 2022
Fix issue #24230 in the Datepicker Views Selection code demo. When selecting a month, set the year
on the form value to the active year on the datepicker.

Previously, this demo would only set the year when clicking on a year in the datepicker, but this
did not account for changing the year with the next/previous year buttons.

Fixes #24230

(cherry picked from commit c8d9125)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
Fix issue angular#24230 in the Datepicker Views Selection code demo. When selecting a month, set the year
on the form value to the active year on the datepicker.

Previously, this demo would only set the year when clicking on a year in the datepicker, but this
did not account for changing the year with the next/previous year buttons.

Fixes angular#24230
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: material/datepicker docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(datepicker): does not change selected year when using the left/right arrows with the Year and Month picker

3 participants